Mt/scrum 137 check timetable duplicated name #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added all team member's phone numbers
Merge the pull_request_template.md file from develop into main
…shes" This reverts commit 761a7eb.
Co-authored-by: minhhaitran08 <[email protected]> Co-authored-by: kevin-lann <[email protected]> Co-authored-by: Austin-X <[email protected]> Co-authored-by: Masahisa Sekita <[email protected]>
…re Architecture Pattern" - Main (#16) Co-authored-by: Kevin Lan <[email protected]>
Co-authored-by: Kevin Lan <[email protected]> Co-authored-by: Austin-X <[email protected]> Co-authored-by: minhhaitran08 <[email protected]> Co-authored-by: Masahisa Sekita <[email protected]>
Co-authored-by: Kevin Lan <[email protected]> Co-authored-by: Austin-X <[email protected]> Co-authored-by: minhhaitran08 <[email protected]> Co-authored-by: Masahisa Sekita <[email protected]> Co-authored-by: Austin-X <[email protected]> Co-authored-by: dawangk <[email protected]> Co-authored-by: kevin-lann <[email protected]> Co-authored-by: MasahisaSekita <[email protected]>
…ering-I/term-group-project-c01w25-project-course-matrix into scrum-57-child-133-Update-timetable-endpoints-for-favorites
Austin-X
reviewed
Mar 14, 2025
Austin-X
reviewed
Mar 14, 2025
Contributor
Austin-X
left a comment
Austin-X
left a comment
There was a problem hiding this comment.
Overall, it looks good. I tested the createTimetable endpoint and the updateTimetable endpoint and the duplicated name check is working.
Similar to my comment on your other PR, this PR has a lot of unrelated changes such as the changes in svgMock.tsx. I believe that the only file that this PR should include is the timetablesController.ts file.
thomasyzy7
approved these changes
Mar 16, 2025
Contributor
thomasyzy7
left a comment
thomasyzy7
left a comment
There was a problem hiding this comment.
Everything is functional, just note that right now the titles differ by capitalization: newTable and newtable are considered 2 different tables.
…//github.com/UTSC-CSCC01-Software-Engineering-I/term-group-project-c01w25-project-course-matrix into mt/scrum-137-check-timetable-duplicated-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SCRUM-137
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Update timetable endpoints to check for duplicated timetable title
Type of change
Checklist: